Open
Conversation
|
@msokolov I just sent an email to @fgeorges and you (your For other readers, I have created a new set of Maven projects for the EXPath modules that I hope iwll be adopted, they can be found here: https://github.com/adamretter/expath-parent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Florent - I'm sending you this as an example of the way I would recommend supporting a maven build for this project. The way Adam has set up the packaging project is workable, too, but overly complicated for my tastes. The main difference I see is that he has set up a system of interdependent "pom" files in a so-called "multi-module" project. This has some advantages, since you can have one repository look like one maven project. However, Maven at its heart is about building a single artifact (like a jar, war, etc), so these multi-module projects are always a little difficult to work with. They don't automatically work in most IDEs for example. The way this one is set up is as two completely separate poms. There is of course a dependency between the two projects; to build this:
cd http-client-java
mvn install
cd ../http-client-saxon
mvn install
The "install" target installs an artifact in your local repository so it is available to be resolved as a dependency. Ultimately you will want to have them posted to "maven central" so they can be resolved over the internet, but that's a little more involved of a process that requires registering with oss.sonatype.org, giving them a PK cert, etc.